Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JSON preety printer for x64 build #5

Closed
wants to merge 1 commit into from
Closed

Fixed JSON preety printer for x64 build #5

wants to merge 1 commit into from

Conversation

karol57
Copy link

@karol57 karol57 commented Sep 14, 2016

I had problems while building library using Mingw-w64, so I wrote a small patch.
Fixed errors:

  1. ./src/gr_logging.cpp:170:37: error: ambiguous overload for 'operator<<' (operand types are 'graphite2::json' and 'size_t {aka long long unsigned int}')
  2. unsigned long int was treated as signed long int at ./src/json.cpp:135:95
  3. ./src/Intervals.cpp:280:17: error: ambiguous overload for 'operator<<' (operand types are 'graphite2::json' and 'ptrdiff_t {aka long long int}')

Oh, and I think it's better to remove json & operator << (integer) throw(); and all integer operators witch casts given number to json::integer, so proper (%hhd, %hhu, %hd, %hu, %d, %u, %ld, %lu) format specifiers can be used. The same with inline json & operator << (json & j, char c) throw ()
If you don't have any objections, tell me and I will add proper commit to this pull request.

@tim-eves
Copy link
Contributor

This has hopefully been fixed in the Win64 building work on master and should definitely be soved in the upcomming C++ modernisation work (c++11 branch)

@tim-eves tim-eves closed this Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants