Upgrade to Node 20.12.2 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed uglify configurations to change based on whether we are in debug mode or not.
Closed
|
One question on this one. I kept the npm |
Upgrading grunt-contrib-uglify to 5.2.2 ensures that we're consistently using a modern version of Uglify that can handle modern syntax.
The CI steps need to be updated to use Node 20. While doing so, we incorporate some additional work: - Update all actions to use the latest versions that run on Node 20 - Update the test matrix to use our .nvmrc file as one of the Node versions to test against - Check for uncommitted changes after installing dependencies
joshuacurtiss
force-pushed
the
jcurtiss/upgrade-node-20.12.2
branch
from
8592d6e
to
7463868
Compare
onebytegone
approved these changes
Aug 26, 2024
I don't really have an option either way. Consistency is good, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the project to Node 20.12.2, including its GitHub Actions job.
This supersedes PR #111, see that PR for additional notes that were taken into consideration.