Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Increase health retries #27

Merged
merged 1 commit into from
Jul 6, 2022
Merged

FIX Increase health retries #27

merged 1 commit into from
Jul 6, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 6, 2022 •
edited
Loading

Issue #11

I've seen quite a lot of sporadic job failures due to unhealthy databases

Example

Waiting for all services to be ready
  /usr/bin/docker inspect --format="{{if .Config.Healthcheck}}{{print .State.Health.Status}}{{end}}" 18ea2fbb88191054825fb20d90a099b366ea97c619d67f0dbbf3cb45b9fb9c90
  unhealthy

https://github.com/creative-commoners/silverstripe-admin/runs/7194459514?check_suite_focus=true

It's not limited to mysql57. I've seen examples online with health-retries set to 10 so increasing for all databases to see if this helps resolve

@emteknetnz emteknetnz mentioned this pull request Jul 6, 2022
Closed
40 tasks
@GuySartorelli GuySartorelli merged commit b028e4c into silverstripe:1.1 Jul 6, 2022
@GuySartorelli GuySartorelli deleted the pulls/1.1/health-timeout branch July 6, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli