Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeDropdownField should use page icons and indicate draft status #232

Open
chillu opened this issue Sep 7, 2017 · 6 comments
Open

TreeDropdownField should use page icons and indicate draft status #232

chillu opened this issue Sep 7, 2017 · 6 comments

Comments

@chillu
Copy link
Member

chillu commented Sep 7, 2017

Overview

Page icons and status are fairly important data points to get context on more complex sites. Otherwise authors might accidentally link to pages which aren't published yet. It's common to add custom icons to pages in SilverStripe, which can be a nice replacement for showing page types

Acceptance Criteria

  • When a tree form field is used with records supporting icons (e.g. pages), these icons show in the list/search views. They don't need to show for the selected record(s)
  • The tree form field indicates when pages aren't published yet ("DRAFT")
  • Developers can choose which status flags to show. For example, "modified" shouldn't show by default, but custom status icons like "review required" might be more important
  • Status icons leave enough room to identify a page by title
@chillu
Copy link
Member Author

chillu commented Sep 7, 2017

@newleeland @clarkepaul this needs design (medium priority)

@clarkepaul
Copy link
Contributor

Cheers added to backlog @chillu

@jamessilverstripe
Copy link

add a page - dropdown
mobile dropdown

@chillu
Copy link
Member Author

chillu commented Sep 12, 2017

Talked with James about this yesterday, it's looking great! Note that I don't think we should show the MODIFIED flag here, since that's kind of irrelevant in this context (hence the AC about "choose which status flags to show"). The point is that it'll have to work with multiple status flags at the same time (e.g. "draft" and a custom "review required")

@clarkepaul
Copy link
Contributor

@chillu You might want to reconsider keeping Modified if you are showing Draft, as you might be linking to a content on a page which isn't published yet. I think we can look at the other custom status as a separate issue as they seem like they would be module specific or non-existent as yet?

@kinglozzer
Copy link
Member

I’m working on a site with a large number of pages and it’s currently quite difficult to navigate via the TreeDropdownField, even when you’re already familiar with the site structure. The visual cues from icons would definitely help

I’d love to take this on, but I fear it’s outside of my limited React knowledge. Presumably this is also partly blocked by the work needed to update the to the new page icons from #574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants