Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error messages to match DSM designs #1172

Open
wants to merge 1 commit into
base: 1.7
Choose a base branch
from
Open

Update error messages to match DSM designs #1172

wants to merge 1 commit into from

Conversation

bergice
Copy link
Contributor

@bergice bergice commented Jan 14, 2021

Resolves #895

@bergice bergice linked an issue Jan 14, 2021 that may be closed by this pull request
Error message when adding large files are not readable #895
Open
@maxime-rainville
Copy link
Contributor

@clarkepaul Do you want to comment on this? While it doesn't fully implement the desired look and feel from the DSM, it takes it closer to it and addresses the immediate problem of the error message being truncated when too long.

Status quo

image

With PR

image

maxime-rainville
maxime-rainville requested changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error messages still get chopped on mobile. The DSM calls for the message to be displayed over multiple lines.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message when adding large files are not readable
2 participants
@bergice @maxime-rainville