Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to page top/bottom or an element #74

Closed
wants to merge 1 commit into from
Closed

Scroll to page top/bottom or an element #74

wants to merge 1 commit into from

Conversation

jeffreyguo
Copy link

It's useful to scroll up/down in a long page, or a page with a floating header.

@@ -800,4 +800,41 @@ public function theTextBeforeAfter($textBefore, $order, $textAfter, $element) {
assertTrue(strpos($text, $textBefore) > strpos($text, $textAfter));
}
}

/**
* @When /^I scroll to page bottom$/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to a correct English sentence: "I scroll to the bottom of the page" and "I scroll to the top of the page"

chillu pushed a commit that referenced this pull request Jan 7, 2015
@chillu
Copy link
Member

chillu commented Jan 7, 2015

Rewritten a bit, and committed through df4a859.

  • Removed the ability to identify elements by class or name, its too fragile to just assume its the first element
  • Added means to select an element by field, link or button name
  • Added examples and docs

@chillu chillu closed this Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants