Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Title validation isn't being tested #10336

Closed
2 tasks done
GuySartorelli opened this issue May 26, 2022 · 1 comment
Closed
2 tasks done

Group Title validation isn't being tested #10336

GuySartorelli opened this issue May 26, 2022 · 1 comment

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented May 26, 2022

Affected Version: 4.10.0, 4.10.1

Description

In #10113 there was some validation added to disallow empty titles via the CMS form, but no behat test was added.
It seems likely the thinking for adding it as form validation was to avoid breaking changes if it was added to validate() directly - but there is no unit test to validate that an empty title can be given to a group programmatically.

Acceptance Critera

  • Add behat test to ensure that blank title throws validation warning in UI
  • Add unit test to ensure that blank Title is allowed when group is created programmatically

PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant