Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Investigate passing $response object to RSSFeed::outputToBrowser() #10984

Closed
sabina-talipova opened this issue Oct 17, 2023 · 1 comment
Closed

TODO: Investigate passing $response object to RSSFeed::outputToBrowser() #10984

sabina-talipova opened this issue Oct 17, 2023 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

Description

Investigate passing $response object to RSSFeed::outputToBrowser() to loosen dependence on global state for easier testing/prototyping so dev can inject custom HTTPResponse instance.

See:

silverstripe-framework/src/Control/RSS/RSSFeed.php

Line 218 in cf78a9d

* TODO: Pass $response object to ->outputToBrowser() to loosen dependence on global state for easier testing/prototyping so dev can inject custom HTTPResponse instance.

This was referenced Oct 17, 2023
Closed
Merged
@GuySartorelli
Copy link
Member

Closing in favour of #11035
We also haven't touched this class in forever, so even if we don't remove it I can't see us making this change.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova