Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually test validation of RequiredFields validator #11011

Open
sabina-talipova opened this issue Oct 18, 2023 · 0 comments
Open

Actually test validation of RequiredFields validator #11011

sabina-talipova opened this issue Oct 18, 2023 · 0 comments
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 18, 2023 •
edited by GuySartorelli
Loading

Description

RequiredFieldsTest performs lots of tests for methods on RequiredFields - but it doesn't actually test the validation which is probably the one thing we have to test.

See:

silverstripe-framework/tests/php/Forms/RequiredFieldsTest.php

Line 9 in cf78a9d

* @todo Test the validation method php()

This was referenced Oct 18, 2023
Closed
Merged
@GuySartorelli GuySartorelli changed the title TODO: RequiredFieldsTest add test case to test the validation method php() Actually test validation of RequiredFields validator Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sabina-talipova