-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fieldtype Bigint #3288
Added fieldtype Bigint #3288
Conversation
Few things:
If we added this, we'd also need to update the other database adapters to support bigint too: |
@@ -0,0 +1,25 @@ | |||
<?php | |||
/** | |||
* Represents a signed 32 bit integer field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it's not a 32-bit field, it's an 8-byte (64-bit) field, but I assume this was copied from Int.php. You might also want to mention in the class docs here that PHP running as 32-bit might not work with Bigint properly, as it would convert the value to a float when queried from the database since the value is a 64-bit one.
This will also need pull requests for postgres, sqlite and mssql. Also, should probably be against master versions so that separate pull requests aren't required for those as well. |
Thanks for the feedback! I've now done the following:
A few questions:
|
…mework into clay Tagged 3.1.6 update to 3.1.6 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch.
cherry-picked against 3 branch |
We needed fieldtype Bigint, so we added it in. Bigint inherits from Int and is very similar.