BUG Upload: File versioning with existing files #3570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayDevlin
force-pushed
the
3565-upload-versioning
branch
from
f52811a
to
2be0947
Compare
|
Good job @JayDevlin, really appreciate your help. I've tested it locally and it works well. |
|
Closed with d474671 I fixed the commit in this PR, but it would be good in future to include the "BUG" tag in the actual commit message (so that when we come to do the changelogs for 3.1.7 it'll get picked up automatically). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a bug in #2921 where an uploaded file with a digit in the filename can not be versioned if a file with the same filename already exists.
Bug:
[User Error] Couldn't fix assets/Uploads/test3.jpg with 3 tries Line 184 in framework/filesystem/Upload.phpBugfix for #3565