MNT: PHP 8, switch from Tavis to Github Actions #47
Conversation
chrispenny
force-pushed
the
mnt/php8-github-actions
branch
from
c53402f
to
8b5993a
Compare
| with: | ||
| dynamic_matrix: false | ||
| extra_jobs: | | ||
| - php: 7.4 |
There was a problem hiding this comment.
Generally better off using the dynamic matrix because it will stay up to date over time e.g. will automatically add an 8.2 job when silverstripe/gha-ci adds support for it - is there a strong reason you have a non-dynamic matrix here?
There was a problem hiding this comment.
@emteknetnz the pgsql tests fail with the standard matrix. I wasn't really trying to fix anything that is already broken, I just wanted to get us up to date with PHP ^8.
Maybe I could raise an Issue regarding PostgreSQL and moving to the standard matrix?
There was a problem hiding this comment.
I think you should retain the dynamic matrix for better standardization
The failure in https://github.com/silverstripe/silverstripe-populate/actions/runs/3146840126/jobs/5115740952 look like it's a quoting issue. There is likely a 'raw' sql like statement that in the populate codebase that just needs some double quotes put around it
There was a problem hiding this comment.
@emteknetnz I've searched around for DB:: and SQL, but I can't find any raw queries being made. This is potentially a bit of a deeper issue?
There was a problem hiding this comment.
@emteknetnz I've raised a follow up Issue:
#48
Hopefully this is acceptable, as we're not currently testing PostgreSQL anyway.
There was a problem hiding this comment.
Yeah I think we'll have to go for this for now. I did a quick investigation into the postgres failure though I didn't see anything obvious. For some reason Title is being converted to title, it may be something in either the framework or postgresql modules rather than populate
|
|
||
| on: | ||
| push: | ||
| pull_request: |
There was a problem hiding this comment.
Should ideally put this on a cron to ensure integration with other modules is working correctly
You can copy the cron syntax from here https://github.com/silverstripe/silverstripe-framework/blob/4/.github/workflows/ci.yml#L8
Also include the account check so that the cron doesn't run on any forks - https://github.com/silverstripe/silverstripe-framework/blob/4/.github/workflows/ci.yml#L15
You'll also need copy paste in keepalive.yml to ensure the cron doesn't stop after 60 days of no repo activity - https://github.com/silverstripe/silverstripe-framework/blob/4/.github/workflows/keepalive.yml
|
@chrispenny I've tagged 2.2.0 for you |
7.4^8support added^9PopulateFactory::createObject().