Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Namespace translations, implement into class localisation calls #305

Merged

Conversation

robbieaverill
Copy link
Contributor

Issue #290

@tractorcow do we need to freeze or fork translations for Subsites 3.x compatibility?

@tractorcow
Copy link
Contributor

@robbieaverill that's what I would do; You'd need to refresh all localisations from transifex, rename the keys (using upgrader), then push up and replace all master keys. To freeze localisations just remove .tx folder from all older branches.

@robbieaverill
Copy link
Contributor Author

robbieaverill commented Sep 7, 2017

Ok, thanks. tx pull didn't update anything, I guess the translations are fairly recently updated from the CWP recipe release. I'll add another PR now to remove the configuration from 3.x compat branches.

PR at #306

I'll merge it up once merged.

@wilr wilr force-pushed the pulls/2.0/namespace-translations branch from a6950d5 to 1704d1d Compare September 10, 2017 23:51
@wilr
Copy link
Member

wilr commented Sep 10, 2017

Rebased, pushed and waiting for test review.

@wilr wilr merged commit 784c3fc into silverstripe:master Sep 11, 2017
@robbieaverill robbieaverill deleted the pulls/2.0/namespace-translations branch September 11, 2017 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants