-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timing for 2.0 release? #44
Comments
We just wanted feedback from the community. I do not think we have any showstopper to make a release. |
Ahh excellent! Thanks for the quick reply! I've had a remarkable amount of success with the pre-release. Everything seems to go as expected. A few notes about the documentation though:
In addition, it's not explained why it states in the readme
I'm actually not sure of that myself? Finally, I know there was an issue about this awhile ago in #17, but is there any plan to add this to the |
Also, just worth saying thank you for all your hard work on this! It's much appreciated by a fellow open-source project maintainer! This is a phenomenal "quality of life" project which will improve my library and users life drastically! |
Python 3.8 is supported. The only compiled code are the plugins themselves. Using the plugins as provided by the system maintainers make sure they were compiled using the same settings used to compile the HDF5 library itself. When one compiles HDF5, there is a file named H5pubconf.h to be used when compiling against the library. We supply the H5pubconf.h file with the sources of hdf5plugin in order to make sure it can be built. Let me illustrate our caveats. On Anaconda, in order to be 100% sure one would have to rely on the H5pubconf.h generated when compiling HDF5 on Anaconda. May be we are too cautious but until the module is more heavily tested we prefer to say that. Previous versions of hdf5plugin were working everywhere with just compression disabled on linux and mac and they had no interference with anything but we prefer to have the package more heavily tested prior to claim it works everywhere. |
Thanks for the feedback! We're about to make a release (early next week). The possible caveat regarding compatibility is that we include the "config" header of HDF5 in the source in order to allow stand-alone build, but that can be mitigated with an option to override it. Regarding conda, to me |
Instead of adding an option to just overwrite the H5pubconf.h file we could provide an option to provide the path to the installed HDF5 library itself so that everything is taken from the installed system. |
@vasole, yes this is what I want to do. |
Hi @vasole thanks so much for the detailed reply. This has been very helpful. Just saw the 2.0.0 release! Congratulations on the big milestone, and know you have (atleat) one very happy user over here! Feel free to close this issue at your convenience. Have a great week! |
Thanks for the positive feedback! BTW, wheels are now available on pypi. |
be68d645b Merge pull request silx-kit#47 from robertu94/master e308ebf85 Merge branch 'master' of github.com:szcompressor/sz3 6198db715 default initalize config 162674f87 Merge pull request silx-kit#46 from mrmbernardi/patch-1 f834756f9 Fix SZFastFrontend::size_est() returning undefined value 13e79072e config bugfix 0ac567a76 Merge pull request silx-kit#45 from szcompressor/hdf5 d6beca327 add config support to hdf5 filter 05965ac2b update 1d lorenzo fast mode d2a03eae4 add lorenzo 1D fast mode fa9a7f179 Merge pull request silx-kit#44 from szcompressor/namespace 2437574dc change namespace from SZ to SZ3, to avoid conflict with SZ2 3236a6eb2 Merge branch 'huffman' 5995fa9f2 update HDF5 filter 1fc15171c update HDF5 filter aadaaeb90 change namespace from SZ to SZ3, to avoid conflict with SZ2 e1af6bea2 change namespace from SZ to SZ3, to avoid conflict with SZ2 bdc4b503b new huffman 9aee288dd Merge pull request silx-kit#43 from mrmbernardi/decompress_output ab7896ec4 update stateNum in preprocess_encode 44839697c Decompress function returns output matching original_dtype f420554d3 update readme 31d7cbb6a add annotation for interfaces d0606d3ae Merge pull request silx-kit#41 from szcompressor/mdz 3443ae347 update readme 1219a336d disable SZ3_DEBUG_TIMINGS by default 09d43dee5 clear runtime output for MDZ f051a8361 support 3D input for MDZ 89f3b7c78 bugfix in smoke test 5a1cf1aad Merge remote-tracking branch 'origin/master' 40e9b3de5 bugfix in smoke test 140e09e9c remove the print information (OpenMP threads = ), which might be annoying and seems unneeded. 1e1dc102e Merge pull request silx-kit#38 from aumuell/uint8 9b2bf8ad5 fix missing uint8_t with GCC 13 f7d865e6e Merge pull request silx-kit#37 from robertu94/hdf5_fix 73674f3db link to MPI when hdf5 is parallel 13f835d54 openmp bugfix 318fe953f openmp bugfix 612b4993d update pysz bce7f1202 Merge pull request silx-kit#32 from exmakhina/master 62d01de0b python: load library from a sensible default path, if not provided ce7fb031e change sprintf to snprintf 1b1abcf39 interp+lorenzo sampling bugfix 9f396935d bugfix git-subtree-dir: src/SZ3 git-subtree-split: be68d645b2e1350adfbd61851c0886b38b876aa5
be68d645b Merge pull request silx-kit#47 from robertu94/master e308ebf85 Merge branch 'master' of github.com:szcompressor/sz3 6198db715 default initalize config 162674f87 Merge pull request silx-kit#46 from mrmbernardi/patch-1 f834756f9 Fix SZFastFrontend::size_est() returning undefined value 13e79072e config bugfix 0ac567a76 Merge pull request silx-kit#45 from szcompressor/hdf5 d6beca327 add config support to hdf5 filter 05965ac2b update 1d lorenzo fast mode d2a03eae4 add lorenzo 1D fast mode fa9a7f179 Merge pull request silx-kit#44 from szcompressor/namespace 2437574dc change namespace from SZ to SZ3, to avoid conflict with SZ2 3236a6eb2 Merge branch 'huffman' 5995fa9f2 update HDF5 filter 1fc15171c update HDF5 filter aadaaeb90 change namespace from SZ to SZ3, to avoid conflict with SZ2 e1af6bea2 change namespace from SZ to SZ3, to avoid conflict with SZ2 bdc4b503b new huffman 9aee288dd Merge pull request silx-kit#43 from mrmbernardi/decompress_output ab7896ec4 update stateNum in preprocess_encode 44839697c Decompress function returns output matching original_dtype f420554d3 update readme 31d7cbb6a add annotation for interfaces d0606d3ae Merge pull request silx-kit#41 from szcompressor/mdz 3443ae347 update readme 1219a336d disable SZ3_DEBUG_TIMINGS by default 09d43dee5 clear runtime output for MDZ f051a8361 support 3D input for MDZ 89f3b7c78 bugfix in smoke test 5a1cf1aad Merge remote-tracking branch 'origin/master' 40e9b3de5 bugfix in smoke test 140e09e9c remove the print information (OpenMP threads = ), which might be annoying and seems unneeded. 1e1dc102e Merge pull request silx-kit#38 from aumuell/uint8 9b2bf8ad5 fix missing uint8_t with GCC 13 f7d865e6e Merge pull request silx-kit#37 from robertu94/hdf5_fix 73674f3db link to MPI when hdf5 is parallel 13f835d54 openmp bugfix 318fe953f openmp bugfix 612b4993d update pysz bce7f1202 Merge pull request silx-kit#32 from exmakhina/master 62d01de0b python: load library from a sensible default path, if not provided ce7fb031e change sprintf to snprintf 1b1abcf39 interp+lorenzo sampling bugfix 9f396935d bugfix git-subtree-dir: src/SZ3 git-subtree-split: be68d645b2e1350adfbd61851c0886b38b876aa5
b3dab4018 Merge pull request silx-kit#60 from szcompressor/newapi d70c22264 update readme 35115beeb update readme 352c1a0f6 update compress api fe6eef7e3 update compress api 75c906dda update compress api ad47f20d2 update compress api 52b4f439c update compress api 7a5447c79 update compress api cb87901dd Merge remote-tracking branch 'origin/newapi' into newapi c1d6504e1 update hdf5 filter 533292f9f Merge branch 'refs/heads/master' into newapi b3dac0c65 update readme 3f478178d Merge pull request silx-kit#56 from juntyr/32bit-hash f8fc2cb33 fix int overflow in quantization e52a2c30f Add support for 32bit systems by falling back to std::unordered_map f6cae37f5 add link to fortran api 90c66bed1 modify MDZ CR calculation to include the first frame which is stored losslessly. 09494b13c fix bug in MDZ for 1D inputs dde630245 add noprediction compressor 47593621f bugfix fdd6dee6e API rewrite data version check a887550ed API rewrite data version check 5bab19c5d API rewrite data version check 1ea5d5b07 API rewrite data version check e78f4832f Add annotation be68d6cbe bug fix for openmp 800c3248e bug fix for interp d06710a55 bug fix for interp 7fc2cb519 bug fix for MDZ 3568914cd Merge remote-tracking branch 'origin/master' 5f835fb74 bug fix for MDZ be68d645b Merge pull request silx-kit#47 from robertu94/master e308ebf85 Merge branch 'master' of github.com:szcompressor/sz3 6198db715 default initalize config 162674f87 Merge pull request silx-kit#46 from mrmbernardi/patch-1 f834756f9 Fix SZFastFrontend::size_est() returning undefined value 13e79072e config bugfix 0ac567a76 Merge pull request silx-kit#45 from szcompressor/hdf5 d6beca327 add config support to hdf5 filter 05965ac2b update 1d lorenzo fast mode d2a03eae4 add lorenzo 1D fast mode fa9a7f179 Merge pull request silx-kit#44 from szcompressor/namespace 2437574dc change namespace from SZ to SZ3, to avoid conflict with SZ2 3236a6eb2 Merge branch 'huffman' 5995fa9f2 update HDF5 filter 1fc15171c update HDF5 filter aadaaeb90 change namespace from SZ to SZ3, to avoid conflict with SZ2 e1af6bea2 change namespace from SZ to SZ3, to avoid conflict with SZ2 bdc4b503b new huffman 9aee288dd Merge pull request silx-kit#43 from mrmbernardi/decompress_output ab7896ec4 update stateNum in preprocess_encode 44839697c Decompress function returns output matching original_dtype f420554d3 update readme 31d7cbb6a add annotation for interfaces d0606d3ae Merge pull request silx-kit#41 from szcompressor/mdz 3443ae347 update readme 1219a336d disable SZ3_DEBUG_TIMINGS by default 09d43dee5 clear runtime output for MDZ f051a8361 support 3D input for MDZ 89f3b7c78 bugfix in smoke test 5a1cf1aad Merge remote-tracking branch 'origin/master' 40e9b3de5 bugfix in smoke test 140e09e9c remove the print information (OpenMP threads = ), which might be annoying and seems unneeded. 1e1dc102e Merge pull request silx-kit#38 from aumuell/uint8 9b2bf8ad5 fix missing uint8_t with GCC 13 f7d865e6e Merge pull request silx-kit#37 from robertu94/hdf5_fix 73674f3db link to MPI when hdf5 is parallel 13f835d54 openmp bugfix 318fe953f openmp bugfix 612b4993d update pysz bce7f1202 Merge pull request silx-kit#32 from exmakhina/master 62d01de0b python: load library from a sensible default path, if not provided ce7fb031e change sprintf to snprintf 1b1abcf39 interp+lorenzo sampling bugfix 9f396935d bugfix git-subtree-dir: src/SZ3 git-subtree-split: b3dab4018425803a55d8073dc55dade7fa46b7b4
Hi team, just wondering what the timing for the v2.0 release will be? I saw the pre-release a few days, ago, and got very excited about being able to include it in the project I maintain in our upcoming 0.4 release (which I'd like to get out in the next two weeks or so).
If there's anything you could use some help on, I'd be happy to contribute a PR or two to help speed along the process. Just let me know!
Best,
Rick
The text was updated successfully, but these errors were encountered: