Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH actions]: packaging shows some errors #2157

Closed
kif opened this issue May 6, 2024 · 4 comments
Closed

[GH actions]: packaging shows some errors #2157

kif opened this issue May 6, 2024 · 4 comments
Assignees
Labels
packaging build, test, package or distribution quality Pay-off some technical dept

Comments

@kif
Copy link
Member

kif commented May 6, 2024

This used to work fine with python3.11.
Since python3.12, we have this error:

(py312) kieffer@mac13:~/workspace/pyFAI$ python -m twine check --strict dist/*
Checking dist/pyfai-2024.4.0a0.tar.gz: FAILED
ERROR    `long_description` has syntax errors in markup and would not be rendered on PyPI.                                       
         line 211: Warning: Cannot scale image!                                                                                  
           Could not get size from "https://readthedocs.org/projects/pyFAI/badge":                                               
           Requires Python Imaging Library.                                                                                      
           Reading external files disabled.                                                                                      
@kif kif self-assigned this May 6, 2024
@kif kif added quality Pay-off some technical dept packaging build, test, package or distribution labels May 6, 2024
@kif
Copy link
Member Author

kif commented May 6, 2024

Apparently, it works on python3.11 but not on python 3.12.
The issue is known for a while on the twine side ...
pypa/twine#908

kif added a commit that referenced this issue May 6, 2024
@kif
Copy link
Member Author

kif commented May 6, 2024

Restricting the version of python used for packaging to 3.11 does not work around properly this issue.
attn @t20100

kif added a commit that referenced this issue May 6, 2024
@kif
Copy link
Member Author

kif commented May 6, 2024

The bug clearly comes from the badges in the Readme.rst file.
Commenting them out is a valid work-around.

@kif
Copy link
Member Author

kif commented May 7, 2024

work-around implemented and reported upstream.

@kif kif closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging build, test, package or distribution quality Pay-off some technical dept
Projects
None yet
Development

No branches or pull requests

1 participant