Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-IP language need to be set to English in order for the renewer to work #11

Closed
rastaralle opened this issue Apr 27, 2022 · 2 comments
Closed

Comments

@rastaralle
Copy link

rastaralle commented Apr 27, 2022

Hi Simao Silva,

during an unsuccessful attempt to get your renewer working, I noticed that the renew.py is searching for a button with the exact test "confirm" in the hosts list. This only is the case if the language is set to English in the No-IP settings.

After I changed to English language in my personal settings on No-IP homepage, your renewer worked like a charm.

As there might be more people running into the same issue, it might be worth mentioning this in the readme.

BTW: Excellent tool!

BR
Ralf

@simao-silva simao-silva changed the title No-IP language to be set to English in order for the renower to work No-IP language need to be set to English in order for the renewer to work Apr 28, 2022
@simao-silva
Copy link
Owner

simao-silva commented Apr 28, 2022

Instead of restricting exclusively to English maybe you can open a PR with the translated name of the confirmation button. Just add an or in the if condition here.

@simao-silva
Copy link
Owner

It should now work with any language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants