Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State and Entity #110

Merged
merged 6 commits into from
Dec 26, 2022
Merged

State and Entity #110

merged 6 commits into from
Dec 26, 2022

Conversation

oleneyl
Copy link
Collaborator

@oleneyl oleneyl commented Dec 26, 2022

State를 명시적으로 넘깁니다.

Trait들은 State를 Protocol을 활용하여 duck-typing 합니다.

Reducer에는 wrap된 state가 전달됩니다.

Concerns

  • 실제 컴포넌트 및 trait의 구현이 자연스러운가?
  • 모든 Trait의 추상 메서드가 state를 인자로 받도록 강제할 것인가?
  • 각 Component의 State들을 정의해야하는데, 어떻게 정의할 것인가?

@oleneyl oleneyl requested a review from icepeng December 26, 2022 12:35
simaple/simulate/component/complex_skill.py Outdated Show resolved Hide resolved
simaple/simulate/component/keydown_skill.py Outdated Show resolved Hide resolved
@oleneyl oleneyl requested a review from icepeng December 26, 2022 13:39
@oleneyl oleneyl merged commit 8750282 into main Dec 26, 2022
@oleneyl oleneyl deleted the feature/state-provider branch December 26, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants