-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterator range #467
Iterator range #467
Conversation
* Biological Structures at Stanford, funded under the NIH Roadmap for * | ||
* Medical Research, grant U54 GM072970. See https://simtk.org/home/simbody. * | ||
* * | ||
* Portions copyright (c) 2008-16 Stanford University and the Authors. * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 2016 here since the code is all new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
I like this! Thanks for making it a separate header. P.S. You should always provide a description for your PRs. This one doesn't have one. |
Needs a changelog mention. |
Thanks for adding the description. Should it say |
Yes; I fixed it. |
1. Edit changelog. 2. Add IteratorRange(std::pair<Iterator,Iterator>&) 3. Add test of IteratorRange.
Ready for review again. |
Ready for review again. |
Beautiful -- thanks for adding the test program! |
This PR adds a helper class that allows using range-based for loops with a pair of iterators: