Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure CPodeFree() does not call cpFreeVectors() unless initialization occurred. #642

Merged
merged 1 commit into from Sep 6, 2018

Conversation

carmichaelong
Copy link
Contributor

@carmichaelong carmichaelong commented Sep 4, 2018

This was the smallest change I could see to address #641. Although the flag (cp_MallocDone) is not specifically set to true right when the vectors are allocated, I think this still follows the intention/flow of the code.

@chrisdembia @sherm1


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #642 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   49.31%   49.31%   -0.01%     
==========================================
  Files         554      554              
  Lines       71104    71105       +1     
==========================================
- Hits        35067    35066       -1     
- Misses      36037    36039       +2
Impacted Files Coverage Δ
...ntegrators/src/CPodes/sundials/src/cpodes/cpodes.c 57.08% <100%> (ø) ⬆️
SimTKcommon/BigMatrix/src/MatrixHelper.cpp 67.31% <0%> (-0.17%) ⬇️
SimTKmath/Optimizers/src/c-cmaes/cmaes.c 52.02% <0%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187d22c...5d48fca. Read the comment docs.

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @carmichaelong and @chrisdembia ! :lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @carmichaelong)

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdembia you have a blocking comment.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @carmichaelong)

Copy link
Member

@chrisdembia chrisdembia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@chrisdembia chrisdembia merged commit 25f5b13 into simbody:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants