Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .syntax-- prefix #4

Merged
merged 3 commits into from
Mar 6, 2017

Conversation

Antikythera
Copy link
Contributor

Fix for the syntax prefix

@simeydotme
Copy link
Owner

hi, @Antikythera , is this something in a new version of Atom?
does it break backwards compatibility?

I actually haven't used Atom for a while; if you could point me to a changelog/blog with info I can merge this! :) thanks for your hard effort! 🙇

(i did search for info, but I couldn't find any 😕 )

@Antikythera
Copy link
Contributor Author

Antikythera commented Mar 6, 2017

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated >within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo->selectors, and prepend all your syntax selectors with syntax--.

From the atom Deprecation Cop :)
atom/atom#12903 This is the commit that introduced this.

@simeydotme
Copy link
Owner

great, thanks so much for the links!
just read through and understand the reasons now... maybe I can try Atom again it seems the perf is getting better! 💃

@simeydotme
Copy link
Owner

simeydotme commented Mar 6, 2017

I do consider this a breaking change, though; So let's put the version up to 1.0.0 and make a note in the readme about version 1.0.0+ of Gooey theme only working with Atom 1.13.0+... how does that sound?

Would you be up for adding those changes to the PR @Antikythera ? if not possible I will amend in due course 😸

@Antikythera
Copy link
Contributor Author

Sounds good 😄
I hope this suffices!

Copy link
Owner

@simeydotme simeydotme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort @Antikythera ! great work.

@simeydotme simeydotme merged commit a201429 into simeydotme:master Mar 6, 2017
@Antikythera Antikythera deleted the feature/fix-deprecations branch March 7, 2017 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants