Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertAll method should use orReplace argument rather than _orReplace flag. #17

Merged
merged 4 commits into from
Apr 23, 2019

Conversation

yohom
Copy link
Contributor

@yohom yohom commented Apr 23, 2019

I removed the _orReplace flag, and unified use orReplace parameters.
BTW, I think insertOrReplace method could be marked as Deprecated, because I add orReplace parameter in insert method too. You can do it later.

@codecov-io
Copy link

Codecov Report

Merging #17 into master will increase coverage by 0.04%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage    80.2%   80.24%   +0.04%     
==========================================
  Files          53       53              
  Lines        1394     1392       -2     
==========================================
- Hits         1118     1117       -1     
+ Misses        276      275       -1
Impacted Files Coverage Δ
moor/lib/src/runtime/statements/insert.dart 95.55% <92.59%> (+1.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e078be...0f3895b. Read the comment docs.

@simolus3 simolus3 changed the base branch from master to develop April 23, 2019 11:54
@simolus3
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants