Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert web encoding to utf8 #2811

Closed
wants to merge 1 commit into from
Closed

Convert web encoding to utf8 #2811

wants to merge 1 commit into from

Conversation

Dall127
Copy link

@Dall127 Dall127 commented Dec 29, 2023

Update web implementation to use UTF-8 for encoding, and updating unit tests

@simolus3
Copy link
Owner

Could you explain the need for these changes a bit more? The intention here is to store a Uint8List as a string because that's the interface the underlyng web API is giving us. Obviously, the string shouldn't be much larger than the original byte array. So a byte value x should be represented by the char code x as well. This is exactly what latin1 is doing. Note that the byte data we want to store is not always a string, this needs to work for all byte sequences, including those that aren't valid utf8.

@Dall127
Copy link
Author

Dall127 commented Dec 29, 2023

That's a valid point; In full honesty, I just barely tested out the purpose on my live site and it didn't actually fix the issue, so I apologize for jumping the gun on making a merge request. I'll make an issue here in a moment describing the actual problem I'm trying to solve.

@Dall127 Dall127 closed this by deleting the head repository Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants