Add a toJson method for serialization.
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
reviewed
Mar 14, 2019
There was a problem hiding this comment.
Thanks for your contribution! 👍
This looks good to me apart from that small dynamic change. I'm also wondering if it makes sense to also generate a .fromJson factory, similar to the fromData factory. But feel free to skip that if you don't need it, I can also add it myself.
| @@ -94,6 +97,17 @@ class DataClassWriter { | |||
| buffer.write(');}\n'); | |||
| } | |||
|
|
|||
| void _writeToJson(StringBuffer buffer) { | |||
| buffer.write('Map<String, Object> toJson() {\n return {'); | |||
There was a problem hiding this comment.
Might be a personal thing, but I'd prefer this to return Map<String, dynamic>, it feels more appropriate as that's also what would be returned by json.decode.
Unless you have a better argument in favor of Object, of course :)
|
Thanks again for your contribution 👍 |
Closed
Closed
This was referenced Jul 11, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2.