Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing lakes inside countries. #5

Closed
simonepri opened this issue Nov 21, 2017 · 9 comments
Closed

[Bug] Missing lakes inside countries. #5

simonepri opened this issue Nov 21, 2017 · 9 comments

Comments

@simonepri
Copy link
Owner

simonepri commented Nov 21, 2017

image

See also here.

@indus
Copy link

indus commented Nov 24, 2017

thats not only a bug but also a feature. I'm really happy for my current project to have your lake-free data because lakes and all the small islands would make too much noise.
So maybe you can add a "inland_water_bodies" version but not replace the current?

@simonepri
Copy link
Owner Author

@indus May I ask you why 'countries-maritime' is not appropriate for your project if you can accept waters bodies?

@indus
Copy link

indus commented Nov 24, 2017

In the moment it is appropriate for my project. But I thought from the title of this issue you are going to change it so it also includes lakes inside country. After that change it wouldn't be appropriate anymore. So i just wanted to ask you to keep both versions - with and without lakes inside countries.

@simonepri
Copy link
Owner Author

simonepri commented Nov 24, 2017

@indus Yes, we will keep both, maybe I'll rename it.
world-lands will be a land-only map (without lakes, rivers, oceans and seas)
world-coasts will be the current world-land.

countries-coastline will be the same
countries-territories will be without waters

What do you think??
Have you a better name? I'm not happy with them.

Just an you provide us an use case for this kind of map?
Thank You!!

@indus
Copy link

indus commented Nov 24, 2017

The map in my project is just the background reference to drop some informations on. For design reasons I only want to show the outline of the world and not a solid filled landmass. By doing so all the wholes (aka lakes) would distract from the information on top because only having the lines of a polygon with wholes give the viewer some challange of what is inside and what is outside - what is land and what is water. Right now I'm using mapboxs vectordata but even on the lowest zoom level it shows Great Lakes, Lake Victoria, Lake Baikal, etc. Now I want to use one of your low resolution geojsons instead.

@indus
Copy link

indus commented Nov 24, 2017 via email

@simonepri
Copy link
Owner Author

You can see the work here #12

@simonepri
Copy link
Owner Author

Version 0.6.0 is here with 78 new maps 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants