Fix (#31): Enhance config options for git sign highlighting. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmclean
reviewed
Feb 9, 2024
simonmclean
approved these changes
Feb 9, 2024
|
Nice work! Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #31 by adding more fine-grained control over the file git signs and their highlight groups. Users can specify their signs as either a string or a table, with the table passed to the
vim.fn.sign_definefunction. The type for the table-type config was created, and theTriptychConfigGitSignstype was updated to use either definition.(Side note: I also updated
validate.shbecause it was notifying about format errors, but not actually doing anything about it.)