1.23-1.32.3: wrong account name elision in tree-mode balance --budget reports

[williamcpierce]

Version

hledger 1.30, mac-aarch64

Reproduction

For this journal file:

~ monthly 2023-08
    (income:employment)           $-100.00
    (income:gifts:cash)           $-100.00

2023-07-01 Expense
    expenses:rent                  $100.00
    income:gifts:cash

Running hledger bal -p "2023-08" --budget prints the following, as expected:

                   ||                Aug 
===================++====================
 income            || 0 [0% of $-200.00] 
 income:employment || 0 [0% of $-100.00] 
 income:gifts:cash || 0 [0% of $-100.00] 
-------------------++--------------------
                   || 0 [0% of $-200.00] 

But if you add the -t (tree) flag to the same command, you instead get:

              ||                Aug 
==============++====================
 income       || 0 [0% of $-200.00] 
   employment || 0 [0% of $-100.00] 
     cash     || 0 [0% of $-100.00] 
--------------++--------------------
              || 0 [0% of $-200.00] 

Which is missing the "gifts" account, making it appear as if "cash" is a subaccount of "employment."

Workaround

Changing the month of the mock transaction to 08 or 09 resolves the issue in this particular example, as does deleting the whole transaction.

Adding --no-elide fixes this issue generally.

Discussion

https://matrix.to/#/!GYlETOAdUBSCcvnEMY:matrix.org/$Fm32JSJs50xGcn4l1v-m5vLz6HQlSr4V4hVg38_0tRw?via=matrix.org&via=vanpetegem.me

Notes from @simonmichael
"IIRC the budget report hides accounts with no budget goals by default, and that is not handled well in this tree report"
"adding --no-elide works around it"

[simonmichael]

I found this hard to debug and hard to fix. I have pushed a best effort fix which essentially forces --no-elide when doing bal --budget --tree. Boring parent accounts won't get elided on the same line as their subaccount as they should, but at least they are not omitted causing wrong reports. Any testing / improvements welcome.

[simonmichael]

I see this regressed in hledger 1.23 in 2021. @williamcpierce, claim your http://hledger.org/REGRESSIONS.html#regression-bounty when convenient. 1.22 and earlier behaved like the latest fix, ie, forcing each displayed account to have its own line.

[williamcpierce]

I see this regressed in hledger 1.23 in 2021. @williamcpierce, claim your http://hledger.org/REGRESSIONS.html#regression-bounty when convenient. 1.22 and earlier behaved like the latest fix, ie, forcing each displayed account to have its own line.

Submitted, thank you!