-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Fix compilation without LANG/LC_ALL set #849
cli: Fix compilation without LANG/LC_ALL set #849
Conversation
@zarybnicky, thanks for making the build more robust. Could you perhaps:
|
94a0310
to
c19f8d3
Compare
I've opened an upstream issue, snoyberg/file-embed#27. I've also added to the commit description, and removed the Nix-related changes (I might open another pull request later, it's nothing urgent, just a nice-to-have). |
Thanks @zarybnicky. I guess we should do a shorter workaround with less code duplication following the suggestions on that issue. |
c19f8d3
to
f108b56
Compare
Oops, didn't mean to click that. |
Alright, third time's the charm. This version just replaces |
Yup, I think so. |
Thanks! |
Embedded files are now assumed to be UTF-8 independently of the system locale. This also replaces the file-embed dependency with
Hledger.Cli.TH
, whereembedStringFile
has been changed to assume UTF-8 (utf8_bom
).Compilation without a locale (e.g. in
nix-shell --pure
ordocker run -it fedora:28 bash
as @talex5 mentioned) now works without a problem.I've also changed thenix:
sections ofstack.yaml
s to use pure nix shells, and added the required dependencies of happy/alex -stack build --nix
works for all build configs. (I'm on NixOS, so I can't actually develop without--nix
, and compiling in a pure shell is also a nice bonus.)Fixes #420, #813.
This is also a better solution to the closed #669.