Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-bootable disks #1

Closed
simonowen opened this issue Mar 7, 2024 · 1 comment
Closed

Support non-bootable disks #1

simonowen opened this issue Mar 7, 2024 · 1 comment

Comments

@simonowen
Copy link
Owner

The current script expects to find cpm3.sys and cpmldr to patch before it considers writing the DPB to the boot sector. Non-bootable data only disks might not have them but would still benefit from the DPB, which would be picked up if the patched CP/M 3 was booted.

After this is relaxed more care should be taken before writing to the end of the boot sector. Currently 0xE5 filler or a decrementing byte pattern is likely safe, and other cases should be refused unless forced.

simonowen added a commit that referenced this issue Mar 9, 2024
Changed the patching to support data disks, which still require a boot
sector DPB to work with a previously booted patched version of CP/M 3.

We now check the boot sector looks normal enough to patch, with either a
byte filler or a a common decrementing byte pattern. Only then do we add the
DPB to the end of the sector. This can still be overridden using the --force
option if the user decides it's safe.

We previously required both CPM3.SYS and CPMLDR to be present and patchable
before patching the boot sector. This has been relaxed to patch them only if
they are present.

The patched disk image is now only written if anything was patched.
@simonowen
Copy link
Owner Author

Fixed in v1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant