modified camb dependency for M1 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 61.45% 61.41% -0.04%
==========================================
Files 30 30
Lines 1930 1928 -2
==========================================
- Hits 1186 1184 -2
Misses 744 744
|
|
Can I ask how you are doing M1 tests? My understanding was that github runners for M1 were not out till summer. (when they are, I may be able to auto-build M1 wheels for pip CAMB) |
|
We are doing them on my M1 mac, check that they pass, then make the PR and check that they pass also the PR tests. That seems the only option so far |
mgerbino
added a commit
that referenced
this pull request
Oct 4, 2023
* modified camb dependency for M1 * explicit tols for two likelihood tests --------- Co-authored-by: Martina Gerbino <bradamante@martina.local> Co-authored-by: Ian Harrison <itrharrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix tox tests on M1 by removing camb from the pip requirements and add it to the conda requirements in soliket-tests.yml