Fix to cross correlation tests, trigger other fails. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is now one tests ( |
|
Looking further, this seems to be to do with difference in how tracer n(z) are dealt with between pyccl 2.3.0 and 2.4.0, see: LSSTDESC/CCL#928 |
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 67.34% 74.26% +6.91%
==========================================
Files 29 29
Lines 1666 1690 +24
==========================================
+ Hits 1122 1255 +133
+ Misses 544 435 -109
|
mgerbino
pushed a commit
that referenced
this pull request
Oct 4, 2023
* fixed shearkappa test * fixes to tests (some still fail, to be fixed separately) * codestyle * fix lensing test package path * revert lensing test packages path * marked lensing lhood tests as xfail, see #77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had somehow picked up a number of test failures. This fixes some to do with mis-specified yaml files and skips the tests for Xcorr, which need to be dealt with.
There are still a couple of now-failing tests.
I will merge this set of test fixes, which will also trigger the other failing tests so we can see them. Then open Issues for the failing tests and we can work on them.