Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random sleep time from pacemaker_test #181

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

jlashner
Copy link
Collaborator

Removes randomness from pacemaker tests.

Description

As @BrianJKoopman noticed, the pacemaker's test_quantized test would occasionally fail due to the sleep-time of the first interval being to large. This PR removes the random sleep time and replaces it with a fixed time of 1/sample_rate/3 which should make the tests reproducible.

Motivation and Context

Fixes bug in pacemaker test suite.

How Has This Been Tested?

Ran tests locally (many times to test consistency).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

@BrianJKoopman BrianJKoopman merged commit b91c9dc into develop Oct 22, 2020
@BrianJKoopman BrianJKoopman deleted the pacemaker_test_fix branch October 22, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants