Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACU motion fixes and "named-positions" feature #603

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

mhasself
Copy link
Member

@mhasself mhasself commented Dec 21, 2023

Description

  • When the "go_to" task runs, and Sun avoidance is enabled, and the platform is already at the target position, there is a risk that the sun safety check will crash, because of the trivial trajectory. This is now fixed.
  • The ACU's ProgramTrack mode will reject points that specify el speeds that exceed the platform limit, even if there is no actual motion in elevation. This caused confusion during testing, so now el_speed is set to 0 in the ProgramTrack data no matter what the user says.
  • A new task, "go_to_named" will cause the platform to go_to a target az, el position that has been configured through the command line. This is mostly to support ocs-web widgets ("go to Home" button) but has other applications, where a script could be written that is general but for which the "home" position is different per-platform.

Motivation and Context

Deals with #601 and ground work for ocs-web:52.

Resolves #601.
Resolves #565.

How Has This Been Tested?

Tested all on SATP3.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Including in generate_scan.  This was due to sun-safety code not
knowing how to check a trivial trajectory.
This prevents the programtrack points from being dropped for no good
reason.
@mhasself
Copy link
Member Author

(Just added fixes to address #565 as well.)

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

socs/agents/acu/agent.py Outdated Show resolved Hide resolved
@BrianJKoopman BrianJKoopman merged commit 0361275 into main Jan 2, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the mhasself/acu-fix-move-to-here branch January 2, 2024 19:18
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
* ACU: fix bug where moving to current position caused crash

Including in generate_scan.  This was due to sun-safety code not
knowing how to check a trivial trajectory.

* ACU: add ability to define named positions, and seek to them

Through a special task.

* ACU: force el_speed to 0 in const el scans

This prevents the programtrack points from being dropped for no good
reason.

* ACU: update function signatures

* ACU: add NamedPostion block to session.data in docstring

* ACU: Fix docstring error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants