Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotation reconstruction convention corrections #9

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

catketchup
Copy link

Hi Mat, this is Hongbo. I am using the rotation reconstruction estimators of symlens. It is a very poweful tool.

I checked the implementation of the rotation estimators and found several convention inconsistencies. I notice https://github.com/simonsobs/symlens/blob/master/symlens/qe.py#L1315 which uses the Yadav et. al. 2009 convention. However, I found the norm in https://github.com/simonsobs/symlens/blob/master/symlens/qe.py#L688, the unnormalized estimator in https://github.com/simonsobs/symlens/blob/master/symlens/qe.py#L909 and the N0 in https://github.com/simonsobs/symlens/blob/master/symlens/qe.py#L746 are inconsistent for rotation field reconstruction and don't give the right result. After I corrected the points above in my branch, I compared the in_alpha x rec_alpha with in_alpha x in_alpha, which match well. I also checked the output N0, which matches well with that used in the SO.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant