Use csv-stringify to convert to CSV #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes escaping data for CSV export
simonv3
approved these changes
Nov 13, 2018
|
@Sohalt I don't have the capacity to release this to sandstorm (I've long since forgotten how too). Is there anything I can do to help you deploy this? |
|
Hi, thanks for merging this so quickly. I'll see what it takes to get this released and get back to you, if I need anything. |
|
Basically just follow this: https://docs.sandstorm.io/en/latest/developing/publishing-apps/ I don't know if the changes on the develop branch since the last release are stable. If so it would make sense to update the changelog accordingly and make a release. If not it might make sense to just cherrypick the csv fix. I can't release the app myself because I don't have the signing key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes escaping data for CSV export