Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error pages do not return CORS header with --cors #453

Closed
simonw opened this issue May 4, 2019 · 1 comment
Closed

Error pages do not return CORS header with --cors #453

simonw opened this issue May 4, 2019 · 1 comment
Labels
bug small

Comments

@simonw
Copy link
Owner

simonw commented May 4, 2019

This is very confusing. It means that if you send invalid SQL you will get back a CORS error, because the resulting 400 page cannot be accessed via JavaScript.
simonw added a commit that referenced this issue May 5, 2019
@simonw
Respect --cors for error pages, closes #453
45c83b4
@simonw simonw closed this as completed May 5, 2019
simonw added a commit that referenced this issue May 5, 2019
@simonw
Respect --cors for error pages, closes #453
831515b
@simonw
Copy link
Owner Author

simonw commented May 5, 2019

Demo: https://latest.datasette.io/fixtures.json?sql=select+blah

Mozilla_Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw