Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--reload should only trigger for -i databases #494

Closed
simonw opened this issue May 29, 2019 · 1 comment
Closed

--reload should only trigger for -i databases #494

simonw opened this issue May 29, 2019 · 1 comment
Assignees
Labels
bug minor Minor bugs (not high priority) small

Comments

@simonw
Copy link
Owner

simonw commented May 29, 2019

Right now it's triggering any time a mutable database changes.

@simonw simonw added small minor Minor bugs (not high priority) labels May 29, 2019
@simonw simonw self-assigned this Jun 24, 2019
@simonw simonw added the bug label Dec 15, 2019
@simonw
Copy link
Owner Author

simonw commented Dec 15, 2019

Just saw this bug again. It's annoying.

Here's the code that causes it:

datasette/datasette/cli.py

Lines 327 to 333 in d6b6c91

if reload:
import hupper
reloader = hupper.start_reloader("datasette.cli.serve")
reloader.watch_files(files)
if metadata:
reloader.watch_files([metadata.name])

files here is the list of mutable databases. immutable is the list of immutable ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug minor Minor bugs (not high priority) small
Projects
None yet
Development

No branches or pull requests

1 participant