Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to show common values if everything is null #547

Closed
simonw opened this issue May 21, 2023 · 1 comment
Closed

No need to show common values if everything is null #547

simonw opened this issue May 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented May 21, 2023

Noticed this:

% sqlite-utils analyze-tables content.db repos -c delete_branch_on_merge --common-limit 20 --no-least
repos.delete_branch_on_merge: (1/1)

  Total rows: 158
  Null rows: 158
  Blank rows: 0

  Distinct values: 0

  Most common:
    158: None

The 158: None there is duplicate information considering we already know there are 158/158 null rows.

@simonw simonw added the enhancement New feature or request label May 21, 2023
@simonw
Copy link
Owner Author

simonw commented May 21, 2023

This will be a cosmetic change to the CLI output only - the options to save data to the database and the Python API function will continue to return [(None, 158)].

I can add an optimization though to avoid running the SQL count query if we know that it's all null.

@simonw simonw closed this as completed in 6027f3e May 21, 2023
simonw added a commit that referenced this issue May 21, 2023
simonw added a commit that referenced this issue May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant