Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow surrogates in parameters #508

Closed
wants to merge 2 commits into from

Conversation

chapmanjacobd
Copy link
Contributor

@chapmanjacobd chapmanjacobd commented Oct 31, 2022

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 96.25% // Head: 96.09% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (2d6a149) compared to base (529110e).
Patch coverage: 63.63% of modified lines in pull request are covered.

❗ Current head 2d6a149 differs from pull request most recent head 43a8c4c. Consider uploading reports for the commit 43a8c4c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   96.25%   96.09%   -0.16%     
==========================================
  Files           4        4              
  Lines        2401     2407       +6     
==========================================
+ Hits         2311     2313       +2     
- Misses         90       94       +4     
Impacted Files Coverage Δ
sqlite_utils/db.py 96.79% <63.63%> (-0.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chapmanjacobd
Copy link
Contributor Author

chapmanjacobd commented Oct 31, 2022

Maybe this is actually a problem in the python sqlite bindings. Given SQLITE's stance on this they should probably use encode('utf-8', 'surrogatepass'). As far as I understand the error here won't actually be resolved by this PR as-is. We would need to modify the data with surrogateescape... :/ or modify the sqlite3 module to use surrogatepass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conn.execute: UnicodeEncodeError: 'utf-8' codec can't encode character
1 participant