Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Click on group of multiple selected elements deselects all #108

Closed
kaimikacolin opened this issue Apr 15, 2021 · 9 comments
Closed
Labels
improvement Something could be changed
Milestone

Comments

@kaimikacolin
Copy link

kaimikacolin commented Apr 15, 2021

Hi All,

This might be a configuration issue on my part, but I'm wondering if the library supports this behavior.

Behavior 1
With SelectionJS:

  1. Drag Select multiple items
  2. Click on one of the items
  3. Result: all items are deselected

Behavior 2
With any OS file system:

  1. Drag Select multiple items
  2. Click on one of the items
  3. Result: the item you clicked remains selected

I've written a workaround to emulate Behavior 2 using the 'start' and 'stop' handlers but am I missing something in configuration? Thanks.

@simonwep
Copy link
Owner

Hey :) This is actually done in 51c8c0f and will be part of v2.1.0 which I'm going to release this weekend. I already noticed the lack of consistency between OS selection and selectionjs (see #106).

@simonwep simonwep added the improvement Something could be changed label Apr 16, 2021
@simonwep simonwep added this to the v2.1.0 milestone Apr 16, 2021
@kaimikacolin
Copy link
Author

Thanks for the quick response, I will wait for that release!

@kaimikacolin
Copy link
Author

Hello, just wanted to check in on that 2.1 release? Thank you!

@simonwep
Copy link
Owner

simonwep commented May 7, 2021

Sorry, it's released now :)

@kaimikacolin
Copy link
Author

Awesome! Have you made that the default behavior, or is there a configuration change?

@simonwep
Copy link
Owner

simonwep commented May 8, 2021

This is a core-adjustment and changes the default behaviour :) I think what you've describes is the way it should behave therefor I didn't make it opt-in.

@kaimikacolin
Copy link
Author

Hi! I updated to the new version and it seems to be working well with the new scenario, but I'm seeing another issue where the tiles are selected on drag in a browser default type of way?

Has anyone else reported this? Thanks.

@kaimikacolin
Copy link
Author

Ah, I see your note related to 2.0.3 and that worked well. Thank you!

@simonwep
Copy link
Owner

Yes, instead of blocking events I / we decided to let this be the developers decision :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something could be changed
Projects
None yet
Development

No branches or pull requests

2 participants