fix: No longer blocks text selection in contenteditable #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses issue #97
There are 2 parts to this fix.
selectstart
event withpreventDefault
, we use a CSS value placed on the document body. This allows for the same behaviour (so that text on the web page isn't selected), but no longer blocks the event fromcontenteditable
elements.preventDefault
now only occurs ifallowTouch
istrue
as these aren't necessary on desktop and contributed to preventing the plugin from working well with selectable text in inputs &contenteditable
elements.Note: These changes haven't been heavily tested on mobile