Fixed AM/PM time without "AM/PM" sign to 24H format #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a workaround and not really a fix, and I'm sure that's the reason for no activity on this PR. |
|
It is a workaround but it certainly fix a present bug (at least partially) I just want to think about this a bit more. |
|
Hey, @zilm13 You was totally correct about your fixes. I was just considering the possibility to make the formatting configurable for the end user. Unfortunately there are some inconsistencies between the format that moment.js uses and the one used in the datetimepicker plugin. So I'm dropping this feature for now. So your fixes are added 66c3931...532b672 even though I wasn't able to merge your pull request directly, because I moved quite a few files lately. Besides that I added i18n support for the datetimepicker as well. 🍻 |
This was referenced Sep 11, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an issue: you use AM/PM 12H format for date but AM/PM is not displayed. Moreover, if you open any entity to edit, datetime field will be filled with time without AM/PM in 12H format, so after save if it's PM it will flush to AM. Here's a small fix: just moved to 24H format.