Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try pg.js if pg didn't exist #65

Merged
merged 1 commit into from
Sep 13, 2014
Merged

Conversation

knownasilya
Copy link

Allows to use pg without C++ stuff.

@knownasilya
Copy link
Author

@simov Would love to get this merged, since it would make it usable for me.

@simov
Copy link
Owner

simov commented Aug 5, 2014

OK, I got your point, and this will probably go in, can you fix the indentation though? + your commit contains one more file with file permissions changed

@knownasilya
Copy link
Author

@simov fixed, would love if you could deploy this today 😄

@simov
Copy link
Owner

simov commented Aug 5, 2014

This will be published to npm in the next release, which won't be today, since I just released a version today and there are plenty of tasks scheduled for the next release.

In the meantime you can refer to your fork in package.json, or this repo when your code get into master.

@knownasilya
Copy link
Author

It was worth a try 😉

@simov
Copy link
Owner

simov commented Aug 5, 2014

I just want to test everything as thoroughly as possible, which certainly gets time. The main place for the automated tests is here but the configuration itself is not fully automated atm, so it's not advisable to spend time trying to run it yet

@knownasilya
Copy link
Author

@simov just a friendly reminder that this is still here.

@simov
Copy link
Owner

simov commented Sep 9, 2014

I know, if you take a look at my last commits you'll know what I'm up to.

@simov simov merged commit ada79b0 into simov:master Sep 13, 2014
@simov
Copy link
Owner

simov commented Sep 13, 2014

Merged. The missing part was this 834e4cc that way the error can be propagated back to where it can be handled properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants