-
Notifications
You must be signed in to change notification settings - Fork 5
Problem: Cyclic import if loading extensions prior to simphony itself #291
Conversation
3a4c46b
to
ebc2fc9
Compare
I realized if we import the extension package prior to the simphony itself a cyclic import will cause a failure in loading engine metadata information. I moved dependencies to |
b1df02c
to
e78b4be
Compare
Another suggestion I would make would be to put Looks fine to me (assuming the tests are fixed, which looks to me simple, but I could be wrong) |
Another alternative would be to move imports to the module-level functions. This is generally justified by having to avoid import cycles. |
Current coverage is 96.51%@@ master #291 diff @@
==========================================
Files 47 48 +1
Lines 3806 3814 +8
Methods 0 0
Messages 0 0
Branches 571 571
==========================================
+ Hits 3673 3681 +8
Misses 44 44
Partials 89 89
|
This will not solve the issue. Loading extensions happen upon importing
Yes this is possible. However, it implies relying on extension developers to do this (because this only happens when the first import is triggered from within an extension), which I prefer to avoid.
I will rename the package. |
I think the one thing that is blocking you is the |
I removed that. It is not necessary (and not blocking anything either). |
Looks good! 👍 |
Solution: re-organize packages and fix #290.