Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Fixes incorrect call in _add_mesh #318

Merged
merged 4 commits into from
Aug 25, 2016

Conversation

stefanoborini
Copy link
Contributor

I suspect this is supposed to be add_edges...

I suspect this is supposed to be add_edges...
@roigcarlo
Copy link
Member

Indeed, copy paste error :(

@codecov-io
Copy link

codecov-io commented Aug 19, 2016

Current coverage is 72.04% (diff: 100%)

Merging #318 into master will increase coverage by 0.19%

@@             master       #318   diff @@
==========================================
  Files           107        107          
  Lines          6795       6810    +15   
  Methods           0          0          
  Messages          0          0          
  Branches        803        806     +3   
==========================================
+ Hits           4882       4906    +24   
+ Misses         1873       1867     -6   
+ Partials         40         37     -3   

Powered by Codecov. Last update 7a0d203...ca79ac2

@stefanoborini
Copy link
Contributor Author

@roigcarlo which means that some tests are missing in there. I'll fix that, please don't merge.

@roigcarlo
Copy link
Member

Sure, I am taking a look at it as well.

If I am not mistaken the test should be this one:

def test_adding_and_getting_items(self):
container = self.container
# add items
uids = self._add_items(container)
# get items
for index, expected in enumerate(self.item_list):
self.assertEqual(
self.get_operation(container, uids[index]), expected)

But for some reason is not running properly or is no using edges at all

@mehdisadeghi mehdisadeghi merged commit 4e6f557 into master Aug 25, 2016
@mehdisadeghi mehdisadeghi deleted the feature/fix-for-incorrect-add_mesh-0819-1121 branch August 25, 2016 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants