Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Internalized data #346

Merged
merged 7 commits into from
Nov 10, 2016
Merged

Internalized data #346

merged 7 commits into from
Nov 10, 2016

Conversation

stefanoborini
Copy link
Contributor

@stefanoborini stefanoborini commented Nov 4, 2016

Internalizes the data member without explicit specification. This change needs the removal of "data" from the yaml file. Also fixes floating point misrepresentation. See PR simphony/simphony-metadata#56 and simphony/simphony-metadata#58

@tuopuu
Copy link
Contributor

tuopuu commented Nov 7, 2016

While at it, use of CUDS.data attribute (in model.py) could be made consistent with the CUDSComponents. Right now there is a conflict with CUDS.name and CUDS.description as they are not stored in the CUDS.data attribute. User can also add a different description/name in the data attribute which makes no sense. It should be enough to have only one name/description attribute in the model.

@mehdisadeghi
Copy link
Contributor

While at it, use of CUDS.data attribute (in model.py) could be made consistent with the CUDSComponents.

Good point. I'll make a couple of PRs which will include that.

@mehdisadeghi
Copy link
Contributor

@stefanoborini since simphony/simphony-metadata#56 is closed let's see how we can proceed with this PR.

@stefanoborini
Copy link
Contributor Author

@mehdisadeghi please review #350 first. It's unrelated, but I want to merge that one and #348 to reduce chance for conflicts.

@mehdisadeghi mehdisadeghi merged commit dcfdfa3 into master Nov 10, 2016
@mehdisadeghi mehdisadeghi deleted the internalized-data branch November 10, 2016 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants