-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Roon #10044
Add Roon #10044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeterShaggyNoble - there's a stroke on the source icon, which can be expanded, merged, and then included in our path. Comparing source in red against your PR in black - I'm seeing the below differences:
You're right! I missed that. But, confusingly, the version in the footer doesn't have the |
As stated by @adamrusted, they use a bolder icon almost everywhere but their homepage (ex. social media, https://help.roonlabs.com/portal/en/home, https://blog.roonlabs.com/). I think it would look better here. https://roonlabs.com/wp-content/uploads/roon_logo.svg that can be found in the footer at https://help.roonlabs.com/portal/en/home might be workable. |
Thanks, @service-paradis, I've updated based on that. I can't do better than a precision of 5, though, without the left side of the "n" shifting down 🙁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# New Icons - 2K (#10322) - Air Transat (#10121) - Animal Planet (#10314) - BentoBox (#10284) - Deepgram (#10281) - Gameloft (#10291) - Gitconnected (#10258) - KuCoin (#10326) - Magic (#10307) - Metasploit (#10274) - MUO (#10296) - Pushbullet (#10305) - Rockstar Games (#10294) - Roon (#10044) - Salla (#10308) - Saudia (#9178) - Take-Two Interactive Software (#10302) - TeePublic (#10279) - Tilda Publishing (#10325) - Top.gg (#10240) - Uphold (#10304) - Vectary (#10297) - ZAP (#10230) # Updated Icons - Google Chat (#10257) - Tauri (#9537) - Yoast (#9398)
Issue: Closes #9786 (cc: Templarian/MaterialDesign#7077)
(Well, ain't that fecking typical, I pick one rejected brand icon request from MDI from over 2 years' worth of a personal backlog, double check it hasn't already been requested here, submit a PR, and hours later discover a request for it here under old branding! 🙄)
Similarweb rank: 168948
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Icon from SVG in source footer. Colour from website stylesheet.