Added ZAP Icon

[hahwul]

Issue: closes #10217

Similarweb rank:

• https://www.similarweb.com/website/zaproxy.org (384064)
• https://github.com/zaproxy/zaproxy (11.6k stars)

Checklist

• I updated the JSON data in _data/simple-icons.json
• I optimized the icon with SVGO or SVGOMG
• The SVG viewbox is 0 0 24 24

[PeterShaggyNoble]

Thanks for the contribution, @hahwul 👍🏻 My first instinct would have been to give it the same monochrome treatment you did, but, after reviewing their site, I think we should follow the treatment seen in their website footer.

Also, I'm getting #00549e from the stylesheet for the colour.

And, as it's one of the very first things mentioned on their homepage, we should include the full name as an alias.

[hahwul]

@PeterShaggyNoble
Thank you for the feedback! As you suggested, I will revise the icon by referring to the footer :D

[hahwul]

@PeterShaggyNoble
I've updated! I'd appreciate your feedback :D

Old	New

[PeterShaggyNoble]

Well, that's odd, the new version is passing our linting despite being off-center and too high; we'll need to look into that.

That aside, I am seeing some differences between your version and the one in their website's footer. Here's an example, with yours in red. Would you mind having another look at that, please?

[hahwul]

Hello again @PeterShaggyNoble :D
The original SVG size in the footer had a slight variation between x and y.

I adjusted it to be 24x24 to match both dimensions, which might have caused a very subtle change in proportions. Could this potentially be an issue? The files included in the pull request have been modified to have dimensions of 24x24.

[PeterShaggyNoble]

The might be the cause of the linter passing when it shouldn't, alright. But it doesn't account for the differences I'm seeing; if I resize yours to the correct relative height they're still there.

Could you try again, keeping the height relative to the width when you scale it down to 24dp?

[hahwul]

memo

Svg and viewbox

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>ZAP</title><path d="M9.378.003.102 3.997a.167.168 0 0 0-.032.29L2.48 6a11.684 11.69 0 0 0-.005.008l2.771 1.986a.167.168 0 0 1-.026.289l-1.218.535a.172.172 0 0 0-.03.29l5.33 3.848a.167.168 0 0 1-.032.29l-1.584.63a.167.168 0 0 0-.022.298l12.2 7.046a11.684 11.69 0 0 0 .017-.013l.906.524a.163.163 0 0 0 .139.002.167.168 0 0 0 .006-.002.163.163 0 0 0 .079-.1.167.168 0 0 0 .004-.028.163.163 0 0 0-.029-.122l-.6-.757-5.247-6.632a.167.168 0 0 1 .09-.267l1.716-.421a.167.168 0 0 0 .086-.267l-3.96-4.98a.167.168 0 0 1 .073-.263l1.357-.453a.167.168 0 0 0 .082-.258L9.568.07a.158.158 0 0 0-.13-.068.14.14 0 0 0-.06 0zm2.937.616A11.684 11.69 0 0 0 11.1.702l4.207 5.975a1.068 1.069 0 0 1 .137.942 1.036 1.037 0 0 1-.67.66l-.357.118 3.321 4.194a1.068 1.069 0 0 1 .171.995 1.05 1.05 0 0 1-.737.67l-.638.154 4.457 5.657A11.684 11.69 0 0 0 24 12.309 11.684 11.69 0 0 0 12.315.62ZM2.063 6.766A11.684 11.69 0 0 0 .63 12.31 11.684 11.69 0 0 0 12.315 24a11.684 11.69 0 0 0 6.788-2.218L7.216 14.917a1.054 1.055 0 0 1 .135-1.888l.367-.145-4.268-3.11a1.059 1.06 0 0 1 .19-1.811l.064-.028z"/></svg>

Size check

Linting

[PeterShaggyNoble]

I'm still seeing the same differences in that new version, @hahwul, when comparing with the SVG in the website's footer.

[hahwul]

@PeterShaggyNoble
Resizing the original SVG with a fixed aspect ratio triggers linting issues. I just committed changes, but I'm wondering if there could still be differences in this version. (When I check with svgdiff, there is a slight variance – it shows 100% before running the npx svg command and 99.68% after)

[PeterShaggyNoble]

Gave it a try myself and it was trickier than it first looked. Came up with the following, though, if you want to use it:

M15.1449 14.1032a.17.17 0 0 1 .0865-.2689l1.7154-.4203c.1261-.0367.1364-.1735.1236-.2288a.1655.1655 0 0 0-.0216-.0401L13.071 8.1627c-.0727-.102-.0294-.2272.0741-.2658l1.3445-.4327a.1669.1669 0 0 0 .0804-.2565L9.5568.0804a.1545.1545 0 0 0-.1886-.068L.099 4.0304a.17.17 0 0 0-.0309.2905l5.1678 3.6718a.1607.1607 0 0 1 .068.1515c-.0015.063-.0488.1081-.0557.1144l-.0402.0247-1.2146.5316a.17.17 0 0 0-.0897.0958v.0402a.1824.1824 0 0 0 .068.1545c1.7749 1.281 3.5502 2.5614 5.3254 3.8418.109.0844.0741.243-.0402.2937l-1.5793.6181c-.1282.054-.1401.2298-.0217.2998l13.1142 7.5724c.1507.0627.2904-.1097.1978-.2442l-5.823-7.3838zm.1483-7.4024a1.0694 1.0694 0 0 1 .136.9272 1.0447 1.0447 0 0 1-.6676.6615l-.3616.1174 3.3195 4.191a1.0478 1.0478 0 0 1-.5656 1.6722l-.6182.1545 4.4816 5.6778A11.677 11.677 0 0 0 12.3168.6305c-.4142 0-.8221.0217-1.2363.0619zM7.211 14.9284a1.0509 1.0509 0 0 1 .139-1.8822l.3771-.1453L3.4587 9.81a1.0509 1.0509 0 0 1 .1916-1.8112l.0618-.0278-1.6906-1.1868a11.68 11.68 0 0 0 17.098 15.021Z

[hahwul]

I experimented with different solutions but couldn't resolve the issue. Ultimately, I utilized the data you provided and made a commit. Everything seems fine on my local environment, but if there are any problem, please feel free to let me know!

[service-paradis]

LGTM 🎉
Thank you both @hahwul and @PeterShaggyNoble!