Magic #10307
Merged
Magic #10307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new icon
|
@PeterShaggyNoble All checks have passed. You can merge now |
PeterShaggyNoble
requested changes
Jan 18, 2024
There was a problem hiding this comment.
@durgeshgowdac, which file did you base your icon off? I'm seeing significant differences when comparing it (in red) to \Magic Logo🪄\SVG\01-Icon\2-Icon_Magic_Black.svg from the zip file of logos they make available.
And we should update the source to match the guidelines.
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
|
@PeterShaggyNoble I have made the changes, please check. |
PeterShaggyNoble
approved these changes
Jan 18, 2024
mondeja
added a commit
that referenced
this pull request
Jan 21, 2024
# New Icons - 2K (#10322) - Air Transat (#10121) - Animal Planet (#10314) - BentoBox (#10284) - Deepgram (#10281) - Gameloft (#10291) - Gitconnected (#10258) - KuCoin (#10326) - Magic (#10307) - Metasploit (#10274) - MUO (#10296) - Pushbullet (#10305) - Rockstar Games (#10294) - Roon (#10044) - Salla (#10308) - Saudia (#9178) - Take-Two Interactive Software (#10302) - TeePublic (#10279) - Tilda Publishing (#10325) - Top.gg (#10240) - Uphold (#10304) - Vectary (#10297) - ZAP (#10230) # Updated Icons - Google Chat (#10257) - Tauri (#9537) - Yoast (#9398)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #10303
Website: https://www.magic.link/
Guidelines: https://magic.link/brand-assets
Similarweb rank: 83,573
Similarweb link: https://www.similarweb.com/website/magic.link/#overview
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24