Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Salla #10308

Merged
merged 11 commits into from Jan 18, 2024
Merged

Conversation

jyotimanglani
Copy link
Contributor

@jyotimanglani jyotimanglani commented Jan 17, 2024

image

Issue: closes #10292

Similarweb rank:228,755

…e icons folder: - Icon SVG: icons/salla.svg - Brand color: #BBF3E5 Updated metadata in _data/simple-icons.json.
@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 17, 2024
@PeterShaggyNoble PeterShaggyNoble changed the title Add Salla Dev icon Add Salla Jan 17, 2024
@PeterShaggyNoble
Copy link
Member

Thanks for the contribution, @jyotimanglani 👍🏻

I've just now found a branding site for Salla which includes icons and colours. Would you mind double checking the changes in your PR against what's available there before we proceed to review, please?

@jyotimanglani
Copy link
Contributor Author

Thanks, @PeterShaggyNoble, I'll review and align my changes with the official branding site for Salla.

@jyotimanglani
Copy link
Contributor Author

jyotimanglani commented Jan 17, 2024

@PeterShaggyNoble, I've noticed a slight color variation between my logo and the versions on the official branding site. I initially used the hex code BBF3E5 from the website header, but it seems they often use a darker version with the hex code 004956. Should I modify the hex code to match the darker color (004956), or is the current one (BBF3E5) acceptable?

@PeterShaggyNoble
Copy link
Member

I would have initially gone for the darker green when I first saw the request, @jyotimanglani, but the brand guidelines make it pretty clear that the lighter green is actually the primary colour. Of the 3 shades, #BAF3E6 is closest to what they use on the branding site for the backgrounds of the section heading, so that would get my vote.

@jyotimanglani
Copy link
Contributor Author

Thanks, @PeterShaggyNoble! I'll switch to #BAF3E6 as suggested.

@jyotimanglani
Copy link
Contributor Author

@PeterShaggyNoble, I've updated the hex code and pushed changes. Could you share the link or steps to regenerate the icon preview for the PR description?

Thanks!

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyotimanglani, the inner shape of your icon (in red) is misaligned when compared with the icon available in the icons section of the brand guidelines, and I'm also seeing some hairline differences in the outer shape.

We should also update the source to the branding site and add a guidelines entry with the same URL.

You can generate previews at https://wasm.simpleicons.org/preview/ or https://petershaggynoble.github.io/SI-Sandbox/preview/

_data/simple-icons.json Outdated Show resolved Hide resolved
jyotimanglani and others added 3 commits January 18, 2024 17:53
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
@jyotimanglani
Copy link
Contributor Author

@PeterShaggyNoble ,
Thanks for your feedback. I've addressed the misalignments in the inner shape and adjusted the outer shape to match the brand guidelines more closely. Additionally, I've updated the source URL to the branding site and added a guidelines entry with the same URL. Please take a look at the changes, and let me know if further adjustments are needed.
Appreciate your guidance!

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks perfect to me now, @jyotimanglani 👍🏻 Thanks for all your work on this one.

@PeterShaggyNoble PeterShaggyNoble merged commit e2c67e6 into simple-icons:develop Jan 18, 2024
3 checks passed
mondeja added a commit that referenced this pull request Jan 21, 2024
# New Icons

- 2K (#10322)
- Air Transat (#10121)
- Animal Planet (#10314)
- BentoBox (#10284)
- Deepgram (#10281)
- Gameloft (#10291)
- Gitconnected (#10258)
- KuCoin (#10326)
- Magic (#10307)
- Metasploit (#10274)
- MUO (#10296)
- Pushbullet (#10305)
- Rockstar Games (#10294)
- Roon (#10044)
- Salla (#10308)
- Saudia (#9178)
- Take-Two Interactive Software (#10302)
- TeePublic (#10279)
- Tilda Publishing (#10325)
- Top.gg (#10240)
- Uphold (#10304)
- Vectary (#10297)
- ZAP (#10230)

# Updated Icons

- Google Chat (#10257)
- Tauri (#9537)
- Yoast (#9398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Salla
2 participants