New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Salla #10308
Add Salla #10308
Conversation
…e icons folder: - Icon SVG: icons/salla.svg - Brand color: #BBF3E5 Updated metadata in _data/simple-icons.json.
Thanks for the contribution, @jyotimanglani 👍🏻 I've just now found a branding site for Salla which includes icons and colours. Would you mind double checking the changes in your PR against what's available there before we proceed to review, please? |
Thanks, @PeterShaggyNoble, I'll review and align my changes with the official branding site for Salla. |
@PeterShaggyNoble, I've noticed a slight color variation between my logo and the versions on the official branding site. I initially used the hex code BBF3E5 from the website header, but it seems they often use a darker version with the hex code 004956. Should I modify the hex code to match the darker color (004956), or is the current one (BBF3E5) acceptable? |
I would have initially gone for the darker green when I first saw the request, @jyotimanglani, but the brand guidelines make it pretty clear that the lighter green is actually the primary colour. Of the 3 shades, |
Thanks, @PeterShaggyNoble! I'll switch to #BAF3E6 as suggested. |
@PeterShaggyNoble, I've updated the hex code and pushed changes. Could you share the link or steps to regenerate the icon preview for the PR description? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyotimanglani, the inner shape of your icon (in red) is misaligned when compared with the icon available in the icons section of the brand guidelines, and I'm also seeing some hairline differences in the outer shape.
We should also update the source
to the branding site and add a guidelines
entry with the same URL.
You can generate previews at https://wasm.simpleicons.org/preview/ or https://petershaggynoble.github.io/SI-Sandbox/preview/
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
@PeterShaggyNoble , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks perfect to me now, @jyotimanglani 👍🏻 Thanks for all your work on this one.
# New Icons - 2K (#10322) - Air Transat (#10121) - Animal Planet (#10314) - BentoBox (#10284) - Deepgram (#10281) - Gameloft (#10291) - Gitconnected (#10258) - KuCoin (#10326) - Magic (#10307) - Metasploit (#10274) - MUO (#10296) - Pushbullet (#10305) - Rockstar Games (#10294) - Roon (#10044) - Salla (#10308) - Saudia (#9178) - Take-Two Interactive Software (#10302) - TeePublic (#10279) - Tilda Publishing (#10325) - Top.gg (#10240) - Uphold (#10304) - Vectary (#10297) - ZAP (#10230) # Updated Icons - Google Chat (#10257) - Tauri (#9537) - Yoast (#9398)
Issue: closes #10292
Similarweb rank:228,755