Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rome #10113

Merged
merged 3 commits into from
May 20, 2024
Merged

Remove Rome #10113

merged 3 commits into from
May 20, 2024

Conversation

PeterShaggyNoble
Copy link
Member

Issue: closes #10109

Description

Development on Rome has ceased and its GitHub repo has been archived.

@PeterShaggyNoble PeterShaggyNoble added the breaking change Issues or pull requests that include a breaking change and scheduled for the next major release label Dec 15, 2023
@PeterShaggyNoble PeterShaggyNoble added this to the v12.0.0 milestone Dec 15, 2023
@PeterShaggyNoble PeterShaggyNoble marked this pull request as draft December 15, 2023 09:14
@CredenceHamby
Copy link

No reason to remove this, its already there just leave it. Some might still need it regardless of the state of the company/brand.

@PeterShaggyNoble
Copy link
Member Author

@CredenceHamby, if you can provide data to make a case that Rome is still in widespread enough use to qualify as popular then we can consider temporarily keeping it in our collection as a legacy brand.

@adamrusted adamrusted marked this pull request as ready for review May 20, 2024 10:10
@adamrusted
Copy link
Member

Will continue to merge as no reasons given to keep it.

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%. From what I've heard Rome has been fully replaced by the community maintained Biome fork, which we already have a logo in our collection for. No need for a legacy hold!

@adamrusted adamrusted merged commit 45a4908 into simple-icons:develop May 20, 2024
4 checks passed
simple-icons bot added a commit that referenced this pull request May 26, 2024
…enamed icons (v12.0.0)

## New Icons

- Audiobookshelf (#10605) (@21st-centuryman)
- Awwwards (#10539) (@stefanobartoletti)
- Foundry Virtual Tabletop (#10575) (@adamrusted)
- FusionAuth (#10776) (@service-paradis)
- Homepage (#10452) (@21st-centuryman)
- Hugging Face (#9259) (@PratyushJayachandran)
- Kagi (#10976) (@uncenter)
- n8n (#10909) (@CodeShakingSheep)
- Posit (#10987) (@cwickham)
- React Bootstrap (#10921) (@CodeShakingSheep)
- Sartorius (#10967) (@CodeShakingSheep)
- UiPath (#10773) (@Mvlprem)
- unpkg (#10317) (@service-paradis)
- Zigbee2MQTT (#10212) (@PeterShaggyNoble)

## Updated Icons

- Adidas (#10982) (@jglamp)
- FastAPI (#10663) (@uncenter)
- RenovateBot (#10996) (@sisp)

## Removed Icons

- FITE (#10060) (@PeterShaggyNoble)
- Flattr (#10380) (@service-paradis)
- Google Bard (#10453) (@PeterShaggyNoble)
- Integromat (#10152) (@PeterShaggyNoble)
- Niantic (#10979) (@PratyushJayachandran)
- Nintendo Network (#10006) (@adamrusted)
- Rome (#10113) (@PeterShaggyNoble)
- Shotcut (#10043) (@PeterShaggyNoble)
- Skynet (#10504) (@kwypchlo)
- Twitter (#9748) (@adamrusted)

## Renamed Icons

- `Airbrake.io` to `Airbrake` (#10513) (@PeterShaggyNoble)
- `Amazon Web Services` to `Amazon Web Services` (#10391) (@readboy8)
- `RStudio` to `RStudio IDE` (#10999) (@adamrusted)

## SDK Changes

### URL_REGEX -> urlRegex()

The exported const `URL_REGEX` has been removed. Please use `urlRegex()` instead:

```javascript
import {urlRegex} from 'simple-icons/sdk';
const regex = await urlRegex();
```

### .jsonschema.json

Now `.jsonschema.json` file is bundled in our package.

For more details, please see: #10276.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Issues or pull requests that include a breaking change and scheduled for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for removal of Rome
4 participants